https://redmine.documentfoundation.org/https://redmine.documentfoundation.org/favicon.ico?16960560022015-11-21T10:32:09ZThe Document Foundation RedmineInfrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=74972015-11-21T10:32:09ZDavid Ostrovskyd.ostrovsky@gmx.de
<ul></ul><p>Guys,</p>
<p>do we have TDF accounts on google.com and github.com?</p>
<p>When logged in with those accounts, we need to create new<br />applications there and request OAuth2 credential. We would<br />need it to enable OAuth2 plugin on our Gerrit instance. We<br />would want to ceate two applications. Every application<br />contains callback URL that must be used. The callback URLs<br />would be:</p>
<ul>
<li>Application: "TDF Gerrit Code Review", callback = <a class="external" href="https://gerrit.libreoffice.org/oauth">https://gerrit.libreoffice.org/oauth</a></li>
<li>Application: "TDF Gerrit Code Review Staging", callback = <a class="external" href="https://gerrit-test.libreoffice.org/oauth">https://gerrit-test.libreoffice.org/oauth</a></li>
</ul>
<p>I can help with creating and configuring the applications on Google and GitHub.<br />I've also setup the plugin with both Google and GitHub OAuth provider on my<br />Gerrit instance for you to play:</p>
<p><a class="external" href="https://review.idaia.de">https://review.idaia.de</a></p>
<p>I've also verified that the old Google OpenID accounts are linked correctly to new<br />OAuth2 providers (Google OpenID auth scheme was dropped early this year):</p>
mysql> select account_id, registered_on, full_name, preferred_email from accounts;<br /><ins><del>----------</del></ins>---------------------+-------------------+---------------------------+
<table>
<tr>
<td> account_id </td>
<td> registered_on </td>
<td> full_name </td>
<td> preferred_email </td>
<td><br /><ins><del>----------</del></ins>---------------------+-------------------+---------------------------+<br /></td>
<td> 42 </td>
<td> 2015-11-21 11:11:57 </td>
<td> Joe Dow </td>
<td> <a class="email" href="mailto:john.doe@gmail.com">john.doe@gmail.com</a> </td>
</tr>
</table>
<p>After connecting with OAuth2 with the same account, the OAuth2 identity is linked to the existing account that was created using Google OpenID:</p>
<p>mysql> select * from account_external_ids;<br /><ins><del>----------</del></ins>---------------------------------+----------+----------------------------------------------------------------------------------+
| account_id | email_address | password | external_id |<br /><ins><del>----------</del></ins>---------------------------------+----------+----------------------------------------------------------------------------------+
| 4 | <a class="email" href="mailto:john.doe@gmail.com">john.doe@gmail.com</a> | NULL | 1031623528736452451234 |<br /><ins><del>----------</del></ins>---------------------------------+----------+----------------------------------------------------------------------------------+</p>
<p>Changes in gerrit configuration site (gerrit.config):</p>
<p>[auth]<br /> type = OPENID<br /> trustedOpenID=^.*$</p>
<p>[plugin "gerrit-oauth-provider-google-oauth"]<br /> client-id = <client-id><br /> client-secret = <client-secret><br /> link-to-existing-openid-accounts = true</p>
<p>[plugin "gerrit-oauth-provider-github-oauth"]<br /> client-id = <client-id><br /> client-secret = <client-secret></p>
<p>Plugin binary (can be fetched from master branch):</p>
<p><a class="external" href="https://gerrit-ci.gerritforge.com/view/Plugins-master/job/plugin-gerrit-oauth-provider-gh-master/lastSuccessfulBuild/artifact/buck-out/gen/plugins/gerrit-oauth-provider/gerrit-oauth-provider.jar">https://gerrit-ci.gerritforge.com/view/Plugins-master/job/plugin-gerrit-oauth-provider-gh-master/lastSuccessfulBuild/artifact/buck-out/gen/plugins/gerrit-oauth-provider/gerrit-oauth-provider.jar</a></p> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=74982015-11-21T10:33:34ZDavid Ostrovskyd.ostrovsky@gmx.de
<ul><li><strong>Subject</strong> changed from <i>Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub-, Google- and Bitbucket-OAuth2 providers</i> to <i>Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providers</i></li></ul> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=74992015-11-21T10:33:36ZFlorian Effenbergerfloeff@documentfoundation.org
<ul></ul><p>Cloph has credentials and knows how to set it up I assume - can you poke <br />him?</p> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=75442015-11-27T09:22:14ZThorsten Behrens
<ul><li><strong>Assignee</strong> set to <i>Christian Lohmaier</i></li></ul><p>Cloph - any chance to quickly do that?</p> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=75452015-11-27T13:10:31ZFlorian Effenbergerfloeff@documentfoundation.org
<ul></ul><p>My fault, I thought Cloph had access to the respective Google account already, which he hadn't<br />Just given him the credentials so he can have a look - sorry for the delay here!</p> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=75652015-11-27T14:09:02ZFlorian Effenbergerfloeff@documentfoundation.org
<ul></ul><p>Cloph sent OAuth credentials to David now</p> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=77572015-12-10T12:50:25ZChristian Lohmaiercloph@documentfoundation.org
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-4 status-5 priority-2 priority-default closed child" href="/issues/1587">Task #1587</a>: Bump Gerrit version to 2.11.7</i> added</li></ul> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=77592015-12-10T12:50:54ZChristian Lohmaiercloph@documentfoundation.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>setting this one to resolved, as there is separate one to do the actual upgrade</p> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=77602015-12-10T12:51:18ZChristian Lohmaiercloph@documentfoundation.org
<ul><li><strong>Target version</strong> set to <i>Q4/2015</i></li></ul> Infrastructure - Task #1625: Gerrit: Install and configure gerrit-oauth-plugin to enable GitHub- and Google-OAuth2 providershttps://redmine.documentfoundation.org/issues/1625?journal_id=77712015-12-10T14:04:59ZFlorian Effenbergerfloeff@documentfoundation.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>