Infrastructure

Particularly, the actually reason for writing this request is this CL [...]

Sorry, I missed this link: [5].

[5] https://gerrit.libreoffice.org/93724

Did the LibreOffice dev community manifest interest in having that?

Isn't this issue and my call to grant that permission indicates such interest?

I also wouldn't disagree, if you add me instead to core project owner or gerrit admin
group, that I somehow lost in the recent years. :-P

I guess that shm_get or cloph revoked those persmissions from my user?

David Ostrovsky wrote:

Did the LibreOffice dev community manifest interest in having that?

Isn't this issue and my call to grant that permission indicates such interest?

Granted I don't follow the dev list closely, but from here I only see interest from the implementor (who also happen to be a LO dev), not from LO dev community at large. :-P

I also wouldn't disagree, if you add me instead to core project owner or gerrit admin group, that I somehow lost in the recent years. :-P

You probably lost access before that, but it's been decided to trim the list so only infra team members have admin access to the instance.

I only see interest from the implementor (who also happen to be a LO dev), not from LO dev community at large. :-P

See: [1]. I added some reviewers there.

[1] https://gerrit.libreoffice.org/98958

Thanks. (I guess 93724 from msg#1 was a typo.) I don't see any request/feedback/interest from others yet, but that's a start.

To get this moving I guess it would be good to give it a quick heads-up in today's ESC call. Added it to the agenda now.

To get this moving I guess it would be good to give it a quick heads-up in today's ESC call. Added it to the agenda now.

Thanks. To summarize:

Right now only change owner, project owners and site administrators can flip the WIP bit.

Even though, I am a committer, I cannot flip the WIP bit.

If change owner started a change, flipped the WIP bit, and another committer would like to finalize the change, there is currently no way, without open new issue in redmine and ask site admins to flip the bit.

That's exactly where the new permission helps.

Another option would be to grant that permission to much smaller group: Stewards.
However, only very few users are members of that group. So we would probably want
to add more users. If we decide go that route, please add my user to that group ;-)

Even though, I am a committer, I cannot flip the WIP bit.

This is not accurate. The correct statement would have been:

"Even though, I am a committer, I cannot flip the WIP bit of other users changes."

Stephan Bergmann wrote:

To get this moving I guess it would be good to give it a quick heads-up in today's ESC call. Added it to the agenda now.

ESC would be happy with this change, see <https://lists.freedesktop.org/archives/libreoffice/2020-July/085589.html> "ESC meeting minutes: 2020-07-23".

Thanks for the follow-up, done.

Doesn't seem to work. I still don't see "Mark as work in progress"
menu entry in other user changes: [1], e.g. for this CL: [2].

Here is example from gerrit-review for other user change: [3],
where I can flip the WIP bit.
(I am project owner for gerrit project on that site, though).

Unclear to me why this should be apply to branches starting with "libreoffice" and not master though.

I don't follow. How is flipping of WIP/READY bit for a change
is depending on the branch, the change was uploaded for?

[1] https://imgur.com/a/fwbHlrW
[2] https://gerrit.libreoffice.org/c/core/+/93724
[3] https://imgur.com/a/1YD98VW

David Ostrovsky wrote:

Unclear to me why this should be apply to branches starting with "libreoffice" and not master though.

I don't follow. How is flipping of WIP/READY bit for a change
is depending on the branch, the change was uploaded for?

No idea, you are the gerrit expert and you implemented this :-) I'm just puzzled why your proposed change is under [access "^refs/heads/libreoffice.*"] and not something more generic. Does it work if you pick a changed uploaded for libreoffice-7-0 or another branch with the same prefix?

I'm just puzzled why your proposed change is under
[access "^refs/heads/libreoffice.*"] and not something more generic.

Sorry, you are right of course, seems like I screwed it up.
Should be fixed in: [1]. Sorry again and thanks for noticing.

[1] https://gerrit.libreoffice.org/c/Dev-ACL-Template/+/99302

Thanks for approving and merging the fix change.
This works now as expected, see: [1], where I
have just flipped the WIP bit. Thanks again!

[1] https://gerrit.libreoffice.org/c/core/+/93724

David Ostrovsky wrote:

This works now as expected

Cool, thanks for confirming :-)