Project

General

Profile

Actions

Task #2455

closed

ESC report failing

Added by Florian Effenberger over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Target version:
Team - Q1/2018
Start date:
Due date:
% Done:

0%


Description

the scripts will fail if the gerrit review address is not a real gerrit person and a committer:

cron.runESC:mailing error
esc_run.txt:mentoring: analyze gerritERROR: analyze_mentoring failed with 'mentoring@documentfoundation.org'
esc_run.txt:ERROR: analyze_reports failed with 'reviewName'
esc_run.txt:ERROR: report_mentoring failed with list index out of range

We need to check who's listed now for the gerrit catch-all substitution? This will be added by default to any new gerrit submission.
Ideally we have Xisco in there - failing that, Thorsten could act as fallback.
Xisco, can you take care of this? Thanks!

Actions #1

Updated by Xisco Fauli Tarazona over 6 years ago

Ok, I'll take a look at it!

Actions #2

Updated by Florian Effenberger over 6 years ago

Thanks a lot! I have another mail a mentoring topic in my inbox:

I have rolled back the mentoring address to the previous for the esc scripts, with one notable exception, the gerrit catch-all address which previously was set for Thorsten and now just the mentoring address.

Keep an eye for anything blowing or not working properly.

I assume this is the same topic as mentioned in the ticket description. If not, please let me know, so I can create a separate task for that.

Actions #3

Updated by Xisco Fauli Tarazona over 6 years ago

it should be fixed after: https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=ae655e2ad310c367000ff8e01e259721ee11b50d
Someone needs to git pull from the vm174 though. I have no access...

Actions #4

Updated by Xisco Fauli Tarazona over 6 years ago

Hi Florian,
There's one thing I don't understand here. What's the 'gerrit catch-all substitution' meant to do?
I deleted this line 'x1 = statList['people']['']' which failed because is not in the people's dict and x1 is not used in the code afterwards. Am I missing something or the code is wrong?
Regards

Actions #5

Updated by Florian Effenberger over 6 years ago

You mean sudo access to vm174, or something else?
If so, please poke Guilhem so he can set your account up

The Document Foundation Redmine wrote on 2018-01-11 at 12:52:

Someone needs to git pull from the vm174 though. I have no access...

Actions #6

Updated by Florian Effenberger over 6 years ago

There's one thing I don't understand here. What's the 'gerrit catch-all
substitution' meant to do?
I deleted this line 'x1 =
statList['people']['
<mailto:>']' which failed because

<mailto:> is not in the people's dict
and x1 is not used in the code afterwards. Am I missing something or the
code is wrong?

I have no real insight on this - maybe Cloph knows?
Otherwise, best is to raise it during next ESC meeting, someone there
has probably better insight :)

Actions #7

Updated by Xisco Fauli Tarazona over 6 years ago

Hi Florian,
Do you know where the original problem comes from? I've just checked in vm174:/usr/local/bin/esc-analyze.py and the line causing the problem is not there, so someone might have deleted it locally.

Actions #8

Updated by Florian Effenberger over 6 years ago

Do you know where the original problem comes from? I've just checked in

Sadly not, no. Does the error still exist, is that something you can verify?

vm174:/usr/local/bin/esc-analyze.py and the line causing the problem is
not there, so someone might have deleted it locally.

When was the file changed the last time?

Actions #9

Updated by Xisco Fauli Tarazona over 6 years ago

Florian Effenberger wrote:

Do you know where the original problem comes from? I've just checked in

Sadly not, no. Does the error still exist, is that something you can verify?

vm174:/usr/local/bin/esc-analyze.py and the line causing the problem is
not there, so someone might have deleted it locally.

When was the file changed the last time?

it was last modified in -rwxr-xr-x 1 root staff 45665 Jan 1 17:48 esc-analyze.py. Maybe shinnok modified it ?

Actions #10

Updated by Florian Effenberger over 6 years ago

it was last modified in -rwxr-xr-x 1 root staff 45665 Jan 1 17:48
esc-analyze.py. Maybe shinnok modified it ?

Likely... can you ask Guilhem and Cloph (in that order) if they have an
idea? Otherwise ESC call comes to mind

<guilhem> anyway yeah, shinnok did edit that file on Jan 1
<guilhem> Jan 1 15:56:31 vm174 sudo: shinnok : TTY=pts/1 ; PWD=/home/esc-mentoring/libreoffice/dev-tools/esc-reporting ; USER=root ; COMMAND=/usr/bin/vim /usr/local/bin/esc-analyze.py
<guilhem> Jan 1 17:05:42 vm174 sudo: shinnok : TTY=pts/1 ; PWD=/home/esc-mentoring/libreoffice/dev-tools/esc-reporting ; USER=root ; COMMAND=/bin/su pootlebot -
<guilhem> Jan 1 17:46:03 vm174 sudo: shinnok : TTY=pts/2 ; PWD=/home/esc-mentoring/esc ; USER=root ; COMMAND=/usr/bin/vim /usr/local/bin/esc-analyze.py
<guilhem> Jan 1 17:49:21 vm174 sudo: shinnok : TTY=pts/2 ; PWD=/home/esc-mentoring/esc ; USER=root ; COMMAND=/usr/bin/vim /usr/local/bin/esc-analyze.py
<guilhem> Jan 1 18:00:53 vm174 sudo: shinnok : TTY=pts/2 ; PWD=/home/esc-mentoring/esc ; USER=root ; COMMAND=/bin/su pootlebot -
<guilhem> Jan 1 20:33:17 vm174 sshd2338: pam_unix(sshd:session): session closed for user shinnok
<guilhem> that was the whole session that day
<guilhem> then next day
<guilhem> Jan 2 13:22:33 vm174 sudo: shinnok : TTY=pts/2 ; PWD=/home/esc-mentoring/libreoffice/dev-tools/esc-reporting ; USER=root ; COMMAND=/bin/cp esc-report.py /usr/local/bin/esc-report.py
<guilhem> Jan 2 15:57:30 vm174 sshd20423: pam_unix(sshd:session): session closed for user shinnok
<guilhem> (time is CET)

So, shinnok removed it in vm174 but he didn't commit the changes. Now that the problem is gone in repo as well, I think we can close it

Actions #11

Updated by Xisco Fauli Tarazona over 6 years ago

  • Status changed from New to Resolved
Actions #12

Updated by Florian Effenberger over 6 years ago

Seems someone edited my comment, as I didn't post the IRC log here... ;-)
Anyways, do the scripts work now?

Actions #13

Updated by Florian Effenberger about 6 years ago

Florian Effenberger wrote:

Seems someone edited my comment, as I didn't post the IRC log here... ;-)
Anyways, do the scripts work now?

Xisco Fauli Tarazona, ping - do the scripts work now and this ticket can be closed?

Hi Florian,
Yes, they do.
The ticket is already in resolved status, isn't it ?

Actions #14

Updated by Florian Effenberger about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF