Project

General

Profile

Actions

Task #2863

closed

Email notifications enabled for Jenkins jobs break threading for <libreoffice-ci@global.libreoffice.org> mailing list

Added by Stephan Bergmann over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Tags:

Description

As discussed yesterday on freenode #libreoffice-dev:

Apr 17 14:47:50 <samuel_m>    sberg: and I added an email notification step to https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/ so that "notification e-mail will be sent to individuals who have committed changes for the broken build", see https://wiki.jenkins.io/display/JENKINS/Mailer
Apr 17 14:51:14 <sberg>    samuel_m, cloph, any reason to enable that mail notification only for that one job?
Apr 17 14:51:38 <samuel_m>    sberg: can you identify a list of jobs where that would make sense too?
Apr 17 14:51:53 <samuel_m>    I can add it then, but I don't know the purpose of most jobs
Apr 17 14:52:02 <sberg>    samuel_m, I don't care, as I'm subscribed to that mailing list anyway :)
Apr 17 14:57:17 <samuel_m>    cloph, sberg: maybe all of those "Tinderbox on Master for x" 
Apr 17 15:00:09 <samuel_m>    done it now
Apr 17 15:00:27 <samuel_m>    so if you get spammed by Jenkins, it's my fault :)
Apr 17 15:00:57 <samuel_m>    although I configured it to send only one mail when the build fails (even if all following builds fail, no further mail will be sent)

That means that, in addition to "Failure/Still Failing/Fixed!" emails sent to the <> mailing list, similar (but differently worded) "Build failed in Jenkins/Jenkins build is back to normal" emails are also sent to individual committers.

However, I observe that since the above change, the "Failure/Still Failing/Fixed!" emails sent to the <> mailing list often are no longer properly threaded. For example, the two emails

Date: Wed, 17 Apr 2019 21:41:51 +0000 (UTC)
From: ci@libreoffice.org
To: libreoffice-ci@global.libreoffice.org
Message-ID: <1907370684.265.1555537311847.JavaMail.ci@vm145.documentfoundation.org>
Subject: [global-libreoffice-ci] Tinderbox on Master for Windows - Build # 21609 - Failure!

(archived at <https://listarchives.libreoffice.org/global/libreoffice-ci/msg26109.html> "[global-libreoffice-ci] Tinderbox on Master for Windows - Build # 21609 - Failure!") and

Date: Wed, 17 Apr 2019 21:55:20 +0000 (UTC)
From: ci@libreoffice.org
To: libreoffice-ci@global.libreoffice.org
Message-ID: <848999827.268.1555538120823.JavaMail.ci@vm145.documentfoundation.org>
In-Reply-To: <1340270904.263.1555537311454.JavaMail.ci@vm145.documentfoundation.org>
References: <1340270904.263.1555537311454.JavaMail.ci@vm145.documentfoundation.org>
Subject: [global-libreoffice-ci] Tinderbox on Master for Windows - Build # 21610 - Fixed!

(archived at <https://listarchives.libreoffice.org/global/libreoffice-ci/msg26110.html> "[global-libreoffice-ci] Tinderbox on Master for Windows - Build # 21610 - Fixed!") should form a thread, via the second one's In-Reply-To referencing the first one's Message-ID, but that is not the case.

(<https://listarchives.libreoffice.org/global/libreoffice-ci/> unfortunately doesn't expose the raw email headers, but if you look at <https://listarchives.libreoffice.org/global/libreoffice-ci/threads.html&gt;, then emails with dates up to ca. "Wed Apr 17 13:19:17 GMT 2019" are shown properly threaded, while many of the emails with dates since ca. "Wed Apr 17 14:18:55 GMT 2019" are not.

I am subscribed to the <> mailing list, and the missing threading is a pain for me---esp. so given the high email volume on that list.

Actions #1

Updated by Samuel Mehrbrodt over 5 years ago

So I removed the additional mailer setup I added yesterday and instead extended the existing mail plugin to also send a mail to "Culprits".
That means, on the first failed build after the last successful one, all who committed since then will be notified (only once).
They will also be notified when the build is fixed again.

Please let me know if this fixes the threading issue.

Actions #2

Updated by Stephan Bergmann over 5 years ago

Didn't improve things much (if at all). Many of the logical Failure/Still Failing/Fixed! threads at <https://listarchives.libreoffice.org/global/libreoffice-ci/threads.html> as of today are still not threaded via In-Reply-To.

Actions #3

Updated by Samuel Mehrbrodt over 5 years ago

Ok, I reverted all my changes. This should restore the threading for the ML hopefully.
Unfortunately, authors who committed a patch causing CI to fail will now again not be notified.

I have no idea how to do that while not causing this regression, maybe someone from our infra team can have a look at some point.

Actions #4

Updated by Stephan Bergmann over 5 years ago

Oh my, this appears to be broken still. For example, <https://listarchives.libreoffice.org/global/libreoffice-ci/msg26258.html> "https://listarchives.libreoffice.org/global/libreoffice-ci/msg26258.html"

Date: Tue, 23 Apr 2019 18:17:47 +0000 (UTC)
From: ci@libreoffice.org
To: libreoffice-ci@global.libreoffice.org
Message-ID: <256930670.495.1556043467751.JavaMail.ci@vm145.documentfoundation.org>
Subject: [global-libreoffice-ci] Tinderbox on Master for Windows-Debug - Build # 21423 - Failure!

and <https://listarchives.libreoffice.org/global/libreoffice-ci/msg26262.html>
Date: Tue, 23 Apr 2019 19:04:45 +0000 (UTC)
From: ci@libreoffice.org
To: libreoffice-ci@global.libreoffice.org
Message-ID: <1333014367.505.1556046286014.JavaMail.ci@vm145.documentfoundation.org>
In-Reply-To: <1658620678.493.1556043466932.JavaMail.ci@vm145.documentfoundation.org>
References: <1658620678.493.1556043466932.JavaMail.ci@vm145.documentfoundation.org>
Subject: [global-libreoffice-ci] Tinderbox on Master for Windows-Debug - Build # 21424 - Fixed!

are not threaded, but I personally still got another email with
Date: Tue, 23 Apr 2019 19:04:45 +0000 (UTC)
From: ci@libreoffice.org
To: noelgrandin@gmail.com, sbergman@redhat.com
Message-ID: <5962628.503.1556046285781.JavaMail.ci@vm145.documentfoundation.org>
In-Reply-To: <1658620678.493.1556043466932.JavaMail.ci@vm145.documentfoundation.org>
References: <1658620678.493.1556043466932.JavaMail.ci@vm145.documentfoundation.org>
Subject: Jenkins build is back to normal : Tinderbox on Master for
 Windows-Debug #21424

Looks like at least those "back to normal" emails are still sent out?

Actions #5

Updated by Samuel Mehrbrodt over 5 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF