Project

General

Profile

Bug #1549

gerrit "patch submitted" mail: please quote pull command-line with anonymous git URL

Added by Dennis Roczek about 4 years ago. Updated 12 days ago.

Status:
Closed
Priority:
Normal
Category:
Gerrit
Target version:
-
Start date:
Due date:
% Done:

0%

Tags:
EasyHack
URL:

Description

ticket moved from https://bugs.documentfoundation.org/show_bug.cgi?id=64037

Lionel Elie Mamane 2013-04-29 11:13:41 CEST
The "I have submitted a patch" automatic mail from gerrit currently contains:

 To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3615/1

Please make that:

 To pull it, you can do:

    git pull git://gerrit.libreoffice.org/core refs/changes/15/3615/1

So that this command-line works anywhere, anytime, not only when one has properly setup ssh authentication to gerrit on the currently used machine. (My personal case is that I usually have not introduced my crypto smartcard for authentication.)

History

#1 Updated by Guilhem Moulin 12 days ago

  • Category changed from Webserver to Gerrit
  • Status changed from New to Closed
  • Assignee set to Guilhem Moulin

Done, but using https://git.libreoffice.org not git://. It works “even more” everywhere because 9418/tcp is filtered in some firewalls, and plain git:// is deprecated in favor of git-over-HTTPS (using the smart HTTP protocol).

Also available in: Atom PDF