Project

General

Profile

Actions
Copy link

Task #2575

closed

Gerrit missing verified -1 vote on failed build

Added by Florian Effenberger about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Christian Lohmaier
Category:
Gerrit
Target version:
Team - Pool
Start date:
Due date:
% Done:

0%

Tags:
URL:

Description

David mentioned that due to a missing configuration, Gerrit is missing verified minus 1 vote on failed build. If I understood it right (and chances are I didn't ;-) we need:

  • linking between and/or privileges for jenkins user to publish -1 vote including comment in Gerrit
  • granting special rights to certain users to overcome/overrule Jenkins -1 vote

Details are at https://lists.freedesktop.org/archives/libreoffice/2018-March/079683.html and https://lists.freedesktop.org/archives/libreoffice/2018-March/079748.html

Christian Lohmaier, is this something you can look into this week?

Actions
Copy link
 #1

Updated by David Ostrovsky about 6 years ago

Christian Lohmaier: Let me know, if I should grant "Remove Reviewers" permission to "stewards" group in All-Projects in production gerrit.
I have a needed ACL to do that.

Actions
Copy link
 #2

Updated by Florian Effenberger about 6 years ago

Any progress yet? ;-)

Actions
Copy link
 #3

Updated by Christian Lohmaier about 6 years ago

  • Status changed from New to Resolved

the -1 votes have been in place for a couple of weeks already, and also the remove reviewer was already setup in the past/did already work, so setting to resolved.

Actions
Copy link
 #4

Updated by Christian Lohmaier almost 6 years ago

  • Status changed from Resolved to Closed

closing - no complaints from devs on how it works currently with -1/+1 given by jenkins and option to have jenkins removed from reviewers (or "trick the system" by rebasing and not waiting for the build result)

Actions
Copy link

Also available in: Atom PDF