Task #3019
closedPartially broken instant notifications on AskLibO
0%
Description
2 weeks ago I upgraded the OS of the box serving AskLibO, and upgraded the PG cluster to PG11. I also had to upgrade the virtualenvs due to the Python ABI change. Unfortunately something broke on the way, because the Instant Alert system is not reliable anymore. Sometimes it triggers an email, sometimes not. I've not been able to find a clear pattern; I see
Task askbot.tasks.record_post_update_celery_task[…] raised unexpected: DoesNotExist('Post matching query does not exist.',)
[…]
Exception: Post matching query does not exist
lines in the log, which do seem related, but I'm missing the AskBot knowledge to understand where they come from, and why they didn't occur before the upgrade.
I recall we had a similar problem about 1 year ago, with some actions triggering instant alert but not all. You did some magic to fix that, but AFAIK didn't document that. Could you please have a look again, Evgeny Fadeev? And/or point me where to look.
Updated by Mike Kaganski over 4 years ago
The notifications seem to get stuck in some queue, and get delivered when an "update" for the same notification arrives: i.e., when a comment to an answer is added, the notification to the answerer is not delivered; but if later the comment is edited, the original comment content comes as the notification. Next edit of the same comment will push a notification about previous edit, and so on.
Updated by Evgeny Fadeev over 4 years ago
Sorry for missing this ticket and thank you for reminding. Will fix by early next week.
Updated by Guilhem Moulin over 4 years ago
Will fix by early next week.
Thanks! Would be great if you could share your finding and fix too, so perhaps I could do it myself next time :-)
Updated by Mike Kaganski over 4 years ago
Evgeny: I'm sorry to tell that I still don't get new notifications about comments...
Updated by Evgeny Fadeev over 4 years ago
Hmm, I might have an idea now. It may be that the task is executing before the transaction creating the post is committed, will update asap.
Updated by Mike Kaganski over 4 years ago
Evgeny: I'm sorry for pinging, just not sure if you tried something (and then I wanted to notify that it hasn't worked yet).
Updated by Evgeny Fadeev over 4 years ago
Mike, could you test it now please? I've made some modifications, but need a test on the production system to confirm.
Updated by Mike Kaganski over 4 years ago
Saw the request for testing only now, sorry.
Testing seems to be successful (see https://ask.libreoffice.org/en/question/218267/asklibo-message-waiting-icon/?comment=241111#post-id-241111). Thanks!
Updated by Florian Effenberger over 4 years ago
- Status changed from New to Closed
Thanks for reporting back!