Project

General

Profile

Actions

Feature #58

closed

create a custom patchset view for gerrit

Added by Florian Effenberger over 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Tags:

Description

There's a demand for a custom patchset view
cf. http://www.slideshare.net/lucamilanesio/gerrit-how-to-cook-a-plugin-in-only-10-mins

  • have important things on that page without JavaScript clicking
  • the commit message on top
  • the Review, Abandon, Rebase buttons right below that (removing the two useless Diff-Buttons)
  • comments against the latest patch expanded (latest comment first)
  • older comments collapsed (thus taking no space)
  • the latest patchset including a full diff and all inline comments
  • delegate everything else to a 300px right-hand sidebar (a la launchpads bugview layout1):
  • Owner, Branch, Topic, Dates, Reviewers, older versions of the change ...
    => This should allow ideally to review the change with one view, as commit message, diff, relevant comments (if any) are all on one page and visible from the start. Development of such a view can be iterative with input from multiple sources, but needs a driver/project owner.
  • replicate LibreOffice code live to the following, in addition to FreeDesktop
  • GitHub
  • Bitbucket
  • Gitorious etc.
    => improve brand building, making code visible on their OSS browsers, give additional backups, helps with source extensions repository
  1. Check which items are (still) needed with the new or upcoming Gerrit version?
  2. Ask on public developer lists for feedback on unknown items
  3. Split tasks to individual tickets, with a deadline between end-February and end-March, depending on complexity and urgency
Actions #1

Updated by Florian Effenberger about 10 years ago

  • Due date deleted (2014-01-31)
  • Start date deleted (2014-01-14)
Actions #2

Updated by Florian Effenberger about 10 years ago

  • Project changed from 8 to Infrastructure
Actions #3

Updated by Florian Effenberger about 10 years ago

Cloph: Can you please initiate the discussion on this, so we see what's still relevant at all?

Actions #4

Updated by Florian Effenberger almost 10 years ago

Clophs will now send mail to the dev list asking for concrete feedback on what's required and desired. Based on that, either starting to work on that ticket or closing it.

Actions #5

Updated by Christian Lohmaier almost 10 years ago

  • Status changed from Feedback to Closed

feedback was that there's no real pressing problem with the patchview, and David mentioned concerns about patching/deviating from upstream, thus closing it.

Actions

Also available in: Atom PDF