Project

General

Profile

Actions

Task #3386

closed

Error on JA donation page when entering extremely small or large amount for Stripe

Added by Shinji Enoki over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
SilverStripe
Target version:
Team - Q1/2021
Start date:
Due date:
% Done:

0%

Tags:

Description

1. access to https://ja.libreoffice.org/donate/
2. select "金額を入力して通貨を指定してください"
3. make sure it's in JPY. Enter the amount as "10".
4. enter the Optional Email.
5. check the box for reCAPTHA.
6. Push the [Donate via Stripe] button.

The page does not transition and the source code of the page is displayed


Files

donate01.jpg (39.1 KB) donate01.jpg JA donation page Shinji Enoki, 2020-09-23 14:05
donate02.png (98.3 KB) donate02.png Error screen Shinji Enoki, 2020-09-23 14:06
Screenshot from 2021-01-27 20-15-38.png (128 KB) Screenshot from 2021-01-27 20-15-38.png Shinji Enoki, 2021-01-27 12:18
Actions #2

Updated by Stephan Ficht over 3 years ago

  • Assignee set to Christian Lohmaier
  • Target version set to Q4/2020

Florian confirmed to assign ticket to Christian with Q4/2020

Actions #3

Updated by Florian Effenberger over 3 years ago

Thanks for the report! The debugging output has been removed.
For the 10 JPY donation - we need the equivalent of 1 €, otherwise TDF pays more in fees than the donation, and gets negative income.
Can you draft us a text in Japanese asking people to have a minimum amount for this specific reason?
Then Cloph will implement an error message
Thanks! :)

Actions #4

Updated by Florian Effenberger over 3 years ago

  • Status changed from New to Feedback

Shinji, can you let us know the equivalent of 1 €, that we should set as minimum donation value? :) Thanks!

Actions #5

Updated by Shinji Enoki over 3 years ago

Sorry for late reply
EUR-JPY rate fluctuates, so I think 200 yen or more is good

I suggest the following message:
手数料が1ユーロ程度必要なため、金額を指定される場合は200円以上でお願いします。

Actions #6

Updated by Shinji Enoki over 3 years ago

Hi Florian Effenberger,

Could you check my translation message?

I suggest the following message:
手数料が1ユーロ程度必要なため、金額を指定される場合は200円以上でお願いします。

I recommend 200 JPY.
The rate changes every day, so I think it's best to have an easy-to-understand amount.

Actions #7

Updated by Florian Effenberger over 3 years ago

  • Target version changed from Q4/2020 to Q1/2021

Thanks a lot, that looks good - and sorry for not replying earlier!
Christian, can you implement that text on the Japanese donate page?

Actions #8

Updated by Florian Effenberger over 3 years ago

  • Status changed from Feedback to In Progress
Actions #9

Updated by Christian Lohmaier over 3 years ago

  • Status changed from In Progress to Resolved

fixed - special case for JPY with the suggested limit of 200 Yen - done in the form verification stage, before handing over to stripe.

Actions #10

Updated by Florian Effenberger over 3 years ago

Shinji, is everything working as expected? :)

Actions #11

Updated by Shinji Enoki about 3 years ago

I think the small amount problem is fixed.
Christian, Florian, thank you for your fix!

There seems to be a problem even with a large amount of money. Would it be another ticket?

Actions #12

Updated by Florian Effenberger about 3 years ago

Feel free to add the information to this ticket, then we can have a look :)

Actions #13

Updated by Shinji Enoki about 3 years ago

Feel free to add the information to this ticket, then we can have a look :)

Thanks!

If someone enters a large amount of money, for example, 100000000 yen, stripe page will not be displayed and the page where the donation has been completed will be displayed.

1. access to https://ja.libreoffice.org/donate/
2. select "金額を入力して通貨を指定してください"
3. make sure it's in JPY. Enter the amount as "100000000".
4. enter the Optional Email.
5. check the box for reCAPTHA.
6. Push the [Donate via Stripe] button.

ok 10000000
ok 99999999
ng 100000000

I don't think they can transfer 100,000,000 yen with a credit card.
However, there was a Japanese who was surprised by this message, and he sent an email to TDF's contact information last year.
I was informed by Sophie and responded to the inquiry.

So, if it is 100,000,000 yen or more, I think it is better to display an error message that the amount is too large.
However, since it is a rare case, if it is difficult to fix it, I think it is okay without it.

If you can fix it, I would like the following message.
"指定された金額が大きすぎます。もう一度金額を指定しなおしてください。"

Actions #14

Updated by Florian Effenberger about 3 years ago

  • Status changed from Resolved to In Progress
Actions #15

Updated by Christian Lohmaier about 3 years ago

Hi - instead of catching a too-large amount, I'd rather catch any errors from stripe side instead, so would be great if you could prefix the string with something along the lines of: "Sorry, something went wrong. Maybe the amount was too large?" - and I try to include the error description from stripe, but that would be in english. So an additional "Please check the error code below" or something. (I guess in most cases it will read "unknown error", but I'll make sure to have something like "amount too large" or something along those lines.

Actions #16

Updated by Shinji Enoki about 3 years ago

Thank you for considering the fix.
My draft Japanese message is as follows.

"Sorry, something went wrong. Maybe the amount was too large?"
"申し訳ありませんが、問題が発生しました。指定された金額は大きすぎませんか?"

"Please check the error code below"
"以下のエラーメッセージを確認してください"

Actions #17

Updated by Christian Lohmaier about 3 years ago

  • Category set to SilverStripe

Thanks a lot, I'll try to add the error handling this week.

Actions #18

Updated by Christian Lohmaier about 3 years ago

  • Due date set to 2021-02-14
Actions #19

Updated by Christian Lohmaier about 3 years ago

  • Status changed from In Progress to Resolved

I made some error handling go live last Sunday - I combined the two messages, since unfortunately the error-code returned by Stripe in case of a too large amount is not distinguishable from other invalid input (would have to parse another error string for that, and to be honest I don't think many users will hit that specific problem :-))
The upside is that also for other errors like the API server not being available or other errors will not send the user to the thank you page.
(the error handling was added for all languages, with the Japanese string added as a translation)

Actions #20

Updated by Florian Effenberger about 3 years ago

  • Due date deleted (2021-02-14)
Actions #21

Updated by Shinji Enoki about 3 years ago

Thank you for your fix!

I have confirmed that the error message is displayed for over 100000000 JPY.
I think it's working as expected.

Actions #22

Updated by Florian Effenberger about 3 years ago

  • Status changed from Resolved to Closed

Thanks for checking/verifying that! :)

Actions

Also available in: Atom PDF