Task #3584
openStrings containing suggestions take long time to save
0%
Description
Reporting this one encountered by Leo and I think related to:
https://github.com/WeblateOrg/weblate/issues/7300
Mainstream has closed the bug as being an issue on our side.
--------------------------------
When I started, the problem seemed to have been resolved, but at the 10th string problems arose again:
- nl/helpcontent2/source/text/swriter/01.po, tekenreeks 76
Context
02110000.xhp
par_id3149802
help.text
Locatie van bronomschrijving
uXgCi
Locatie van brontekenreeks
02110000.xhp <https://git.libreoffice.org/help/+/libreoffice-7-2/source/text/swriter/01/02110000.xhp#0>
There was a suggestion, I modified it and then it took 22 seconds before being saved.
- nl/helpcontent2/source/text/shared.po, tekenreeks 215
Context
main0650.xhp
par_id3153822
help.text
Locatie van bronomschrijving
ApwuB
Locatie van brontekenreeks
main0650.xhp <https://git.libreoffice.org/help/+/libreoffice-7-2/source/text/shared/main0650.xhp#0>
------------------------------------
Could you have a look? let me know if we should reopen the github issue instead.
Related issues
Updated by Christian Lohmaier over 2 years ago
- Target version set to Q2/2022
exact timestamps would help to diagnose easier, need some time to debug...
Updated by Christian Lohmaier almost 2 years ago
- Status changed from New to In Progress
- Target version changed from Q2/2022 to Q3/2022
I so far miseed the important bit of this thing, namely that it is a suggestion that needs to be accepted and edited by the function in the hover-menu..
Indeed I can reproduce the slowness using that method - there seems to be a DB deadlock situation in this case.
"Fixed tracking suggestions in history." in one of the 4.13 changelog
So need to recheck after update to 4.14
Updated by Christian Lohmaier almost 2 years ago
- Has duplicate Task #3632: Weblate: slow saving of edited suggestions added
Updated by Sophie Gautier over 1 year ago
See the mp4 Mario shared demonstrating the issue:
https://nextcloud.documentfoundation.org/f/1223364
Updated by Christian Lohmaier over 1 year ago
- Due date set to 2023-06-13
- Start date set to 2023-06-09
next weblate update will require a little larger downtime since metric data needs to be converted to a different format.
The problem with editing suggestions is not something that can be solved by a workaround and is caused by our large repositories - from weblate's POV both taking the suggestion in the edit box and then modifying it are two changes that are synced to the git repository only after the edit is submitted, so when user hits save button it first needs to create a commit for the original suggestions (i.e. wait for git lock and all that and wait for git commit completion), and then do another one for the edit. Since we're using weblate's git squash addon to combine multiple commits into a single one those individual commits don't show up in the repo, so one optimization weblate devs will implement is to trigger the save for the suggestion immediately when using the "use and edit" on the suggestion, so when the user then is done with modifying the first save should be completed and should be "hidden from the user"/speed should be the same as regular translation as weblate doesn't need to wait.
Plan to do the update after 7.6.0 beta1 is tagged
Updated by Christian Lohmaier over 1 year ago
- Target version changed from Q3/2022 to Q2/2023
proper target version