Project

General

Profile

Actions

Task #2105

closed

commit & upstream bugfix for "April 31st" in bugzilla query (-6m just substracts month, without taking day-of-month into account)

Added by Christian Lohmaier over 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Bugzilla
Target version:
-
Start date:
Due date:
% Done:

0%

Tags:

Description

It's used in the "find similar issues" search on the guided bugform, there it search for bugs entered in the last six months, using relative date of "-6m", bug bugzilla code
https://github.com/bugzilla/bugzilla/blob/master/Bugzilla/Search.pm#L2269-L2280 ignores any day-of week, so if it happens to be October 31st, the query will start April 31st, that will lead to postgresql error...

simple fix/workaround is to clamp the day to 28 (to also account for February), and thus be at most three days of.

$mday = $mday > 28 ? 28 : $mday; # avoid reference to April 31st or similar

was added to test & prod instance, but not to git repo/upstrem.

Actions #1

Updated by Beluga Beluga over 7 years ago

Upstream report from 2015: https://bugzilla.mozilla.org/show_bug.cgi?id=1200182
Poked Dylan on #bugzilla about it and he said he is going to work on it.

Actions #2

Updated by Florian Effenberger over 7 years ago

How urgent/important is that and who will deal with it if urgent? ;-)

Actions #3

Updated by Jean Spiteri over 7 years ago

What is needed here actually?

Actions #4

Updated by Christian Lohmaier over 7 years ago

  • Status changed from New to Resolved

From our side this is done, the abovementioned workaround is active on our
instance.
Iff/when upstream decides to fix this is up to them of course, we then
(when updating bugzilla to a version with a fix) remove our local fix.

The Document Foundation Redmine <>
schrieb am Di., 13.12.2016, 12:46:

Actions #5

Updated by Christian Lohmaier almost 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF