Feature #589
closedsilverstripe: redirect pages don't offer to open in new window
80%
Description
This is bad for entries to be put into the main navigation, as that leaves the current site unexpectedly.
Either add a setting to the redirector page that can be used to control the behaviour (litte more work, create DataExtension for the RedirectorPage in php)
or just make Redirector pages that link to other sites (i.e.have the RedirectionType = External) open in a new window unconditionally (statement in the template)
Updated by Florian Effenberger over 9 years ago
- Assignee deleted (
Christian Lohmaier)
Updated by Jean Spiteri about 9 years ago
- % Done changed from 0 to 80
Some work on cloph's side is the only thing needed here.
Updated by Jean Spiteri over 7 years ago
A part of the code needed in this task can be found at https://gist.github.com/Liongold/eda3a016778fc1bc0ab0. I believe an edit to the template is also needed to support this.
Updated by Jean Spiteri over 6 years ago
- Status changed from New to In Progress
Again, the link above is outdated. Updated code is available in the newdesign site waitign to copied to the main site.
Updated by Jean Spiteri over 6 years ago
- Category changed from Webserver to SilverStripe
Updated by Florian Effenberger about 6 years ago
- Assignee changed from Jean Spiteri to Christian Lohmaier
Cloph: Jean has been asking
Any progress on the pushing of these changes from newdesign.libreoffice.org to the official site?
Can you let us know if that is on your pile?
The ticket priority is low, but I'd like to know if there is anything blocking. :-)
Important to me is that any solution we deploy is update-proof and doesn't require lots of patching and manual work with each update, so we have to weight the benefits.
Updated by Florian Effenberger about 6 years ago
- Target version set to Pool
Chatted with Cloph about this in person now
Your patch looks good, Cloph will push this to the page soon now - sorry for the delay!
Updated by Jean Spiteri about 6 years ago
Thank you. Can you let me know when it's pushed please?
Updated by Florian Effenberger almost 6 years ago
Cloph, can you give a quick status update? ;-)
Updated by Christian Lohmaier over 5 years ago
will check and deploy this week.
Updated by Florian Effenberger over 5 years ago
Christian Lohmaier wrote:
will check and deploy this week.
Was this done, is it live?
Updated by Florian Effenberger over 4 years ago
- Status changed from In Progress to Closed
No feedback from anyone, ticket five years old - either done or not relevant anymore, so closing