Project

General

Profile

Feature #589

silverstripe: redirect pages don't offer to open in new window

Added by Christian Lohmaier almost 4 years ago. Updated 2 months ago.

Status:
In Progress
Priority:
Normal
Category:
SilverStripe
Target version:
Team - Pool
Start date:
Due date:
% Done:

80%

Estimated time:
Tags:
URL:

Description

This is bad for entries to be put into the main navigation, as that leaves the current site unexpectedly.

Either add a setting to the redirector page that can be used to control the behaviour (litte more work, create DataExtension for the RedirectorPage in php)
or just make Redirector pages that link to other sites (i.e.have the RedirectionType = External) open in a new window unconditionally (statement in the template)

History

#1 Updated by Florian Effenberger over 3 years ago

  • Assignee deleted (Christian Lohmaier)

#2 Updated by Florian Effenberger over 3 years ago

Is this still recent?

#3 Updated by Jean Spiteri over 3 years ago

  • Assignee set to Jean Spiteri

#4 Updated by Jean Spiteri over 3 years ago

  • % Done changed from 0 to 80

Some work on cloph's side is the only thing needed here.

#5 Updated by Dennis Roczek over 2 years ago

  • Category set to Webserver

#6 Updated by Jean Spiteri about 2 years ago

A part of the code needed in this task can be found at https://gist.github.com/Liongold/eda3a016778fc1bc0ab0. I believe an edit to the template is also needed to support this.

#7 Updated by Jean Spiteri about 1 year ago

  • Status changed from New to In Progress

Again, the link above is outdated. Updated code is available in the newdesign site waitign to copied to the main site.

#8 Updated by Jean Spiteri about 1 year ago

  • Category changed from Webserver to SilverStripe

#9 Updated by Florian Effenberger 6 months ago

  • Assignee changed from Jean Spiteri to Christian Lohmaier

Cloph: Jean has been asking

Any progress on the pushing of these changes from newdesign.libreoffice.org to the official site?

Can you let us know if that is on your pile?
The ticket priority is low, but I'd like to know if there is anything blocking. :-)

Important to me is that any solution we deploy is update-proof and doesn't require lots of patching and manual work with each update, so we have to weight the benefits.

#10 Updated by Florian Effenberger 5 months ago

  • Target version set to Pool

Chatted with Cloph about this in person now
Your patch looks good, Cloph will push this to the page soon now - sorry for the delay!

#11 Updated by Jean Spiteri 4 months ago

Thank you. Can you let me know when it's pushed please?

#12 Updated by Florian Effenberger 2 months ago

Cloph, can you give a quick status update? ;-)

Also available in: Atom PDF