Project

General

Profile

Actions

Task #2377

closed

wiki footer broken

Added by Florian Effenberger almost 8 years ago. Updated 20 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Wiki
Target version:
-
Start date:
Due date:
% Done:

0%

Tags:

Description

When Firefox is used with the NoScript plugin, the wiki footer seems to be broken (cf. attached screenshot).
It does not matter whether people are logged in or not.


Files

Screenshot from 2017-09-21 12-40-25.png (33.1 KB) Screenshot from 2017-09-21 12-40-25.png Florian Effenberger, 2017-09-25 09:10
Wiki_Screenshot.png (105 KB) Wiki_Screenshot.png Dennis Roczek, 2020-02-25 23:22
Actions #1

Updated by Florian Effenberger over 7 years ago

  • Assignee deleted (Guilhem Moulin)
  • Target version deleted (Pool)

Given there were no further complaints and this is a minor issue with a special plugin, removing this from Guilhem's pile

Actions #2

Updated by Guilhem Moulin over 5 years ago

  • Status changed from New to Closed

AFAICT no longer relevant, I no longer see the markup when browsing https://wiki.documentfoundation.org anonymously without JavaScript.

Actions #3

Updated by Dennis Roczek over 5 years ago

  • File Wiki_Screenshot.png Wiki_Screenshot.png added
  • Subject changed from wiki footer broken with Firefox NoScript to wiki footer broken
  • Category set to Wiki
  • Status changed from Closed to New

Problem has nothing to do with NoScript; there are two variables which can be modified by the localsetttings.config but there is no possibility to fix both: the footer under the content and the second under the edit field.

There is an open bug report at wmf, but haven't the bug report at the moment. this needs mediawiki hacking to get fixed.

Actions #4

Updated by Beluga Beluga almost 3 years ago

I don't see the original problem, but various people reported a glitch, when using some other wiki language besides English (from the language selector at the top nav).

I confirm I see this with Finnish:

Sisältö on käytettävissä lisenssillä the <a href="https://creativecommons.org/licenses/by-sa/3.0/&quot;&gt;Creative Commons Attribution-ShareAlike 3.0 Unported License</a>, unless otherwise specified. This does not include the source code of LibreOffice, which is licensed under the <a href="https://www.libreoffice.org/download/license/&quot;&gt;Mozilla Public License v2.0</a>. "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our <a href="/TradeMark Policy">trademark policy</a> (see <a href="/Project:Copyrights">Project:Copyrights</a> for details). LibreOffice was based on OpenOffice.org.<br/>If you do not want your writing to be edited mercilessly and redistributed at will, then do not submit it here., ellei toisin ole mainittu.

Actions #5

Updated by Beluga Beluga 6 months ago

Support for raw HTML in the copyright message has been deprecated in the recently released 1.43 and will be removed in the future: https://phabricator.wikimedia.org/T45646

I guess we should just rework the content of the message and use [1], [2] style references and list the links at the bottom? Keep it simple.

Actions #6

Updated by Beluga Beluga 23 days ago

From MW 14.3 release notes:

The localisation messages 'copyright' and 'history_copyright' are deprecated in favor of 'copyright-footer' and 'copyright-footer-history'. The new messages are parsed as wikitext instead of being treated as raw HTML.

So I created https://wiki.documentfoundation.org/MediaWiki:Copyright-footer

However, it is not being picked up in the editing view and I could not find information about what needs to be changed in LocalSettings.php to make it effective. Hopefully Guilhem can help here.

Relevant resources:

Browser and filter all system messages (for example, select Modified and either find copyright in page or filter by it): https://wiki.documentfoundation.org/Special:AllMessages

Help: https://www.mediawiki.org/wiki/Help:System_message

The messages can also be translated via that page by first selecting the language from the dropdown, clicking Filter and then clicking the name link of the page (clicking the Translate link is not relevant in this case as it leads to translatewiki for the upstream localisation).

https://www.mediawiki.org/wiki/Manual:Footer
https://www.mediawiki.org/wiki/Manual:Interface

From what I see, these are not used:
https://wiki.documentfoundation.org/MediaWiki:Copyrightwarning
https://wiki.documentfoundation.org/MediaWiki:Copyrightwarning2

These unused ones are documented in https://www.mediawiki.org/wiki/Manual:Interface/Copyrightwarning

Actions #7

Updated by Dennis Roczek 22 days ago · Edited

Beluga Beluga wrote in #note-6:

From MW 14.3 release notes:

The localisation messages 'copyright' and 'history_copyright' are deprecated in favor of 'copyright-footer' and 'copyright-footer-history'. The new messages are parsed as wikitext instead of being treated as raw HTML.

So I created https://wiki.documentfoundation.org/MediaWiki:Copyright-footer

However, it is not being picked up in the editing view and I could not find information about what needs to be changed in LocalSettings.php to make it effective. Hopefully Guilhem can help here.

Relevant resources:

Browser and filter all system messages (for example, select Modified and either find copyright in page or filter by it): https://wiki.documentfoundation.org/Special:AllMessages

Help: https://www.mediawiki.org/wiki/Help:System_message

The messages can also be translated via that page by first selecting the language from the dropdown, clicking Filter and then clicking the name link of the page (clicking the Translate link is not relevant in this case as it leads to translatewiki for the upstream localisation).

https://www.mediawiki.org/wiki/Manual:Footer
https://www.mediawiki.org/wiki/Manual:Interface

From what I see, these are not used:
https://wiki.documentfoundation.org/MediaWiki:Copyrightwarning
https://wiki.documentfoundation.org/MediaWiki:Copyrightwarning2

These unused ones are documented in https://www.mediawiki.org/wiki/Manual:Interface/Copyrightwarning

That is the basic idea behind https://phabricator.wikimedia.org/T45646 It is not working for us as we are using a complete custom text. This has to be configured in the LocalSettings.config.
In https://www.mediawiki.org/wiki/Manual:$wgAllowRawHtmlCopyrightMessages you can see the mess WikiMedia did: they instantly removed all the stuff again in MediaWiki 1.45 again.

In https://www.mediawiki.org/wiki/Manual:$wgRightsText#Example they explain only some part and missed how to provide some important info (Impressum and "other legal stuff") with working links for logged-in and logged-out user including providing links or to overwrite the translation completely.

I need to setup again some up-to-date MediaWiki to play around with the existing (and new?) possibility if there is finally a solution lasting for longer than two releases. My original ticket was merged at some point by one of the above linked phabricator mess. I'm really happy that we will stay at Bugzilla. ;-)

To keep the actual problem summarized:
  • grabbing some MediaWiki:-onwiki-sites do not fix the problem logged out versus logged-in people
  • has nothing to do with noscript any longer (I believe)
  • TDF need to provide some legal links, easiest in "Footer"-text without using yet another extension which breaks again (3 or 4 were already used or evaluated in ~2015)
  • LocalSettings.config was no solution, option was integrated and again removed
    • still missing a solution to get a useful translation integrated.
Actions #8

Updated by Beluga Beluga 22 days ago

Dennis Roczek wrote in #note-7:

To keep the actual problem summarized:
  • grabbing some MediaWiki:-onwiki-sites do not fix the problem logged out versus logged-in people
  • has nothing to do with noscript any longer (I believe)
  • TDF need to provide some legal links, easiest in "Footer"-text without using yet another extension which breaks again (3 or 4 were already used or evaluated in ~2015)
  • LocalSettings.config was no solution, option was integrated and again removed
    • still missing a solution to get a useful translation integrated.

Based on what you said, I don't understand what the problem is with using https://wiki.documentfoundation.org/MediaWiki:Copyright-footer It is translatable after all as I mentioned.

If the current footer text is indeed hardcoded in LocalSettings.php then that explains why the newly-created MediaWiki:Copyright-footer is not having an effect.

Actions #9

Updated by Dennis Roczek 22 days ago

Beluga Beluga wrote in #note-8:

Based on what you said, I don't understand what the problem is with using https://wiki.documentfoundation.org/MediaWiki:Copyright-footer It is translatable after all as I mentioned.

There are two places where this footer is displayed:
  1. under the edit summary field
  2. under the content page itself at the very bottom

MediaWiki code might have changed, I only can say that a few years ago / a few releases before, it was not possible to get both displayed footer in sync displaying links and get the markup right and thus working for both places. Hence, it was tried to get fixed using hardcoded language in the LocalSettings.config, but this didn't solve the problem.

Feel free to try any combination, but be aware that there is server side and client side caching involved and a potential solution need double and tripled checked.

If the current footer text is indeed hardcoded in LocalSettings.php then that explains why the newly-created MediaWiki:Copyright-footer is not having an effect.

Correct.

Actions #10

Updated by Beluga Beluga 20 days ago

  • Status changed from New to Closed

Thanks to moonmoon on #mediawiki giving support and Guilhem tweaking the setup first on testwiki, I was able to get us to a working solution. This is now in production.

To document a bit, the $wgRightsText config needs to be set in LocalSettings.php for the copyright pages to be picked up by the system and shown in the footer. This text is now "Creative Commons Attribution-ShareAlike 3.0 Unported License" and the $wgRightsUrl config points to the respective license link.

Using the $1 variable in the copyright pages was recommended by moonmoon to prevent future confusion, so I made use of it. All of these now have the same content:

https://wiki.documentfoundation.org/MediaWiki:Copyright-footer
https://wiki.documentfoundation.org/MediaWiki:Copyrightwarning
https://wiki.documentfoundation.org/MediaWiki:Copyrightwarning2

MediaWiki:Copyrightwarning was required for the edit mode footer.

Actions #11

Updated by Beluga Beluga 20 days ago

Tested now a Finnish translation and it is working. Added a mention to our wiki translation resource: https://wiki.documentfoundation.org/index.php?title=TDF_Wiki%2FMultilingual&diff=828651&oldid=770364

Actions

Also available in: Atom PDF